[CALCITE-6622] Negative logarithms should return NaN or -Inf, not throw an IllegalArgumentException

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.38.0
• Component/s: core
• Assignee: Unassigned
• Reporter: Claude Brisson
• Created: 09/Oct/24 09:36
• Updated: 17/Oct/24 19:01

Description

Since |CALCITE-6312], log functions in SqlFunctions do throw an IllegalArgumentException, instead as an ArithmeticException as before.

In terms of errors categorization, it is more precise to revert to the former behavior, as IllegalArgumentException is more suited to structural errors which do not depend on the actual values, whereas we would expect negative logarithms to throw the same kind of error as an integer division by zero for instance.

An engine implementation could choose to have a different behaviors depending on the thrown errors, for instance to just abort the constants reduction for an illegal argument versus letting the arithmetic exception propagate to alert the user.