Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-6608

RexBuilder#makeIn should create EQUALS instead of SEARCH for single point values

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 1.39.0
    • core

    Description

      RexBuilder.makeIn(inputRef(0), ImmutableList.of(literal(100)))
      

      Current behavior:

      SEARCH($0, Sarg[100])
      

      Proposed behavior:

      =($0, 100)
      

      The EQUALS operator is simpler than the SEARCH operator and it is handled better by other components. Although, the SEARCH to EQUALS transformation is already something that is done during simplification not every piece of code calls the simplifier.

      This basic simplification could also be done directly inside the makeIn method when the caller passes a single point value.

      Attachments

        Issue Links

          Activity

            People

              zabetak Stamatis Zampetakis
              zabetak Stamatis Zampetakis
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: