[CALCITE-6598] In RelDataTypeSystem, deprecate methods getMaxNumericScale and getMaxNumericPrecision

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.38.0
• Assignee: Unassigned
• Reporter: Julian Hyde
• Created: 25/Sep/24 23:27
• Updated: 17/Oct/24 22:41
• Resolved: 17/Oct/24 22:41

Description

In interface RelDataTypeSystem, deprecate getMaxNumericScale() in favor of getMaxScale(SqlTypeName) and getMaxNumericPrecision() in favor of getMaxPRecision(SqlTypeName).

This will make them consistent with getMinScale(SqlTypeName) and getMinPrecision(SqlTypeName) (both added in CALCITE-6560).

For each pair of methods (one with SqlTypeName and one without), if we allow people to choose which to override, things will become too complicated. So, in release 1.39 we will make getMaxNumericScale() and getMaxNumericPrecision() methods final (in addition to being deprecated as of release 1.38). People should only override getMaxScale(SqlTypeName) and getMaxPrecision(SqlTypeName).

This will be a breaking change in 1.39 – projects that have overridden these methods will be broken – but at least we will have given them one release warning.

Issue Links

• is related to: CALCITE-6560 Allow types with negative scale