Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Noticed while working on CALCITE-652 and using maven's dependency plugin. Our pom's aren't in sync with our usage.

      It looks like we can use the dependency to run the report in our verify phase, and even optionally fail the build when things creep.

      [INFO] --- maven-dependency-plugin:2.8:analyze (default-cli) @ calcite-linq4j ---
      [WARNING] Used undeclared dependencies found:
      [WARNING]    org.hamcrest:hamcrest-core:jar:1.3:test
      ...
      [INFO] --- maven-dependency-plugin:2.8:analyze (default-cli) @ calcite-core ---
      [WARNING] Used undeclared dependencies found:
      [WARNING]    com.google.guava:guava:jar:14.0.1:compile
      [WARNING]    com.fasterxml.jackson.core:jackson-annotations:jar:2.1.1:compile
      [WARNING]    com.fasterxml.jackson.core:jackson-core:jar:2.1.1:compile
      [WARNING]    org.hamcrest:hamcrest-core:jar:1.3:test
      [WARNING] Unused declared dependencies found:
      [WARNING]    mysql:mysql-connector-java:jar:5.1.20:test
      [WARNING]    net.hydromatic:foodmart-data-hsqldb:jar:0.3:test
      [WARNING]    net.hydromatic:scott-data-hsqldb:jar:0.1:test
      ...
      [INFO] --- maven-dependency-plugin:2.8:analyze (default-cli) @ calcite-example-csv ---
      [WARNING] Used undeclared dependencies found:
      [WARNING]    com.fasterxml.jackson.core:jackson-core:jar:2.1.1:compile
      [WARNING]    com.google.guava:guava:jar:14.0.1:compile
      [WARNING]    com.fasterxml.jackson.core:jackson-databind:jar:2.1.1:compile
      [WARNING] Unused declared dependencies found:
      [WARNING]    org.apache.calcite:calcite-avatica:jar:1.2.0-incubating-SNAPSHOT:compile
      ...
      [INFO] --- maven-dependency-plugin:2.8:analyze (default-cli) @ calcite-mongodb ---
      [WARNING] Used undeclared dependencies found:
      [WARNING]    org.hamcrest:hamcrest-core:jar:1.3:test
      [WARNING]    com.google.guava:guava:jar:14.0.1:compile
      [WARNING] Unused declared dependencies found:
      [WARNING]    org.apache.calcite:calcite-avatica:jar:1.2.0-incubating-SNAPSHOT:compile
      ...
      [INFO] --- maven-dependency-plugin:2.8:analyze (default-cli) @ calcite-plus ---
      [WARNING] Used undeclared dependencies found:
      [WARNING]    org.hamcrest:hamcrest-core:jar:1.3:test
      [WARNING] Unused declared dependencies found:
      [WARNING]    org.apache.calcite:calcite-avatica:jar:1.2.0-incubating-SNAPSHOT:compile
      ...
      [INFO] --- maven-dependency-plugin:2.8:analyze (default-cli) @ calcite-spark ---
      [WARNING] Used undeclared dependencies found:
      [WARNING]    org.eclipse.jetty:jetty-util:jar:9.2.7.v20150116:compile
      [WARNING]    junit:junit:jar:4.11:compile
      [WARNING]    org.scala-lang:scala-library:jar:2.10.3:compile
      [WARNING]    com.google.guava:guava:jar:14.0.1:compile
      [WARNING] Unused declared dependencies found:
      [WARNING]    org.apache.calcite:calcite-avatica:jar:1.2.0-incubating-SNAPSHOT:compile
      [WARNING]    xerces:xercesImpl:jar:2.9.1:compile
      [WARNING]    xalan:xalan:jar:2.7.1:compile
      ...
      [INFO] --- maven-dependency-plugin:2.8:analyze (default-cli) @ calcite-splunk ---
      [WARNING] Used undeclared dependencies found:
      [WARNING]    org.hamcrest:hamcrest-core:jar:1.3:test
      [WARNING]    com.google.guava:guava:jar:14.0.1:compile
      ...
      [INFO] --- maven-dependency-plugin:2.8:analyze (default-cli) @ calcite-ubenchmark ---
      [WARNING] Unused declared dependencies found:
      [WARNING]    org.apache.calcite:calcite-linq4j:jar:1.2.0-incubating-SNAPSHOT:compile
      [WARNING]    org.openjdk.jmh:jmh-generator-annprocess:jar:0.7.1:provided
      

        Activity

        Hide
        ndimiduk Nick Dimiduk added a comment -

        Installs dependency:analyze-only as part of the verify target. Cleaned up resulting warnings, adding ignore configuration for dependencies that are not resolved in byte code.

        https://github.com/apache/incubator-calcite/pull/70

        Show
        ndimiduk Nick Dimiduk added a comment - Installs dependency:analyze-only as part of the verify target. Cleaned up resulting warnings, adding ignore configuration for dependencies that are not resolved in byte code. https://github.com/apache/incubator-calcite/pull/70
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/ba07b09a .
        Hide
        julianhyde Julian Hyde added a comment -

        Resolved in release 1.2.0-incubating (2015-04-16)

        Show
        julianhyde Julian Hyde added a comment - Resolved in release 1.2.0-incubating (2015-04-16)

          People

          • Assignee:
            ndimiduk Nick Dimiduk
            Reporter:
            ndimiduk Nick Dimiduk
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development