Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0-incubating
    • Component/s: None
    • Labels:

      Description

      Per thread on dev list titled "Avatica handling of connection state", this ticket implements such an rpc.

      1. 655.txt
        21 kB
        Nick Dimiduk
      2. CALCITE-655.00.patch
        26 kB
        Nick Dimiduk
      3. CALCITE-655.01.patch
        32 kB
        Nick Dimiduk

        Activity

        Hide
        julianhyde Julian Hyde added a comment -

        I have a hunch that in the longer term we may want to combine several kinds of modifications (to connection, statement, result set) but I may be wrong, so it's better to go for Nick Dimiduk's more straightforward scheme.

        Nick can you mark ConnectionProperties as experimental, add some tests, and I'll commit.

        Show
        julianhyde Julian Hyde added a comment - I have a hunch that in the longer term we may want to combine several kinds of modifications (to connection, statement, result set) but I may be wrong, so it's better to go for Nick Dimiduk 's more straightforward scheme. Nick can you mark ConnectionProperties as experimental, add some tests, and I'll commit.
        Hide
        ndimiduk Nick Dimiduk added a comment -

        Sure, I can comment as experimental.

        I have a new patch that make connectionSync lazy for RemoteMeta, will post shortly. Adding test coverage is not possible at the moment, because all the juicy bits are in RemoteMeta, which is not instantiated in the current framework of RemoteDriverTest. Further, due to package protections, it seems blocked by the lack of CALCITE-652. Let me do that work, then rebase.

        Show
        ndimiduk Nick Dimiduk added a comment - Sure, I can comment as experimental. I have a new patch that make connectionSync lazy for RemoteMeta, will post shortly. Adding test coverage is not possible at the moment, because all the juicy bits are in RemoteMeta, which is not instantiated in the current framework of RemoteDriverTest. Further, due to package protections, it seems blocked by the lack of CALCITE-652 . Let me do that work, then rebase.
        Hide
        ndimiduk Nick Dimiduk added a comment -

        Parking a patch pre-rebase of CALCITE-652. It makes connectionSyn a lazy RPC call in RemoteMeta (though still a 2nd RPC, rather than piggy-backing on associated data RPC), converts Meta.ConnectionProperties into an interface, and adds the comments regarding interface stability.

        Show
        ndimiduk Nick Dimiduk added a comment - Parking a patch pre-rebase of CALCITE-652 . It makes connectionSyn a lazy RPC call in RemoteMeta (though still a 2nd RPC, rather than piggy-backing on associated data RPC), converts Meta.ConnectionProperties into an interface, and adds the comments regarding interface stability.
        Hide
        ndimiduk Nick Dimiduk added a comment -

        Adds test coverage.

        Patch created on top of other refactoring changes, see https://github.com/ndimiduk/incubator-calcite/tree/avatica-to-prod

        Show
        ndimiduk Nick Dimiduk added a comment - Adds test coverage. Patch created on top of other refactoring changes, see https://github.com/ndimiduk/incubator-calcite/tree/avatica-to-prod
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/304eb70c .
        Hide
        julianhyde Julian Hyde added a comment -

        Resolved in release 1.2.0-incubating (2015-04-16)

        Show
        julianhyde Julian Hyde added a comment - Resolved in release 1.2.0-incubating (2015-04-16)

          People

          • Assignee:
            julianhyde Julian Hyde
            Reporter:
            ndimiduk Nick Dimiduk
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development