Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-654

Tighten up AvaticaStatement#execute semantics

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      I discovered some mismatch between the existing behavior of JdbcMeta#fetchAndExecute and the more pedantic expectations of my underlying JDBC implementation, particularly around mutation and DDL statements. AvaticaStatement should be more careful about how it represents the underlying response, and we need a way to convey that over the wire.

      1. CALCITE-654.00.patch
        9 kB
        Nick Dimiduk
      2. CALCITE-654.01.patch
        9 kB
        Nick Dimiduk

        Activity

        Hide
        ndimiduk Nick Dimiduk added a comment -

        Here's some work in this direction. Adds test that conforms to the behavior of underlying HSQL.

        FYI Julian Hyde.

        Show
        ndimiduk Nick Dimiduk added a comment - Here's some work in this direction. Adds test that conforms to the behavior of underlying HSQL. FYI Julian Hyde .
        Hide
        ndimiduk Nick Dimiduk added a comment -

        Correct check style warnings.

        Show
        ndimiduk Nick Dimiduk added a comment - Correct check style warnings.
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/0ea085b7 .
        Hide
        julianhyde Julian Hyde added a comment -

        Resolved in release 1.2.0-incubating (2015-04-16)

        Show
        julianhyde Julian Hyde added a comment - Resolved in release 1.2.0-incubating (2015-04-16)

          People

          • Assignee:
            ndimiduk Nick Dimiduk
            Reporter:
            ndimiduk Nick Dimiduk
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development