Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 1.37.0
    • None
    • mongodb-adapter
    • None

    Description

      MongoAdapter should use MongoDB builders[1] instead of constructing queries from strings to reduce the number of mistakes, such as quoting errors[2].

      [1] - https://www.mongodb.com/docs/drivers/java/sync/v4.3/fundamentals/builders/
      [2] - https://issues.apache.org/jira/browse/CALCITE-6509

      Attachments

        Issue Links

        Activity

          julianhyde Julian Hyde added a comment -

          I very much agree that we should use builders. However, should we use MongoDB's builders or our own? I would require that MongoDB's builders are stable (i.e. don't change between releases, even major releases) and have a convenient API for our purposes. My inclination is to use MongoDB's builders. But please assure me that they are fit for purpose.

          julianhyde Julian Hyde added a comment - I very much agree that we should use builders. However, should we use MongoDB's builders or our own? I would require that MongoDB's builders are stable (i.e. don't change between releases, even major releases) and have a convenient API for our purposes. My inclination is to use MongoDB's builders. But please assure me that they are fit for purpose.
          dmsysolyatin Dmitry Sysolyatin added a comment - - edited

          Julian Hyde , that is a good question. I am not a MongoDB expert and can not say exactly . However, from this documentation, it seems they break binary compatibility quite frequently.

          dmsysolyatin Dmitry Sysolyatin added a comment - - edited Julian Hyde , that is a good question. I am not a MongoDB expert and can not say exactly . However, from this documentation , it seems they break binary compatibility quite frequently.
          julianhyde Julian Hyde added a comment -

          I don't intend to dissuade you from fixing this. You (or whoever wishes to fix this bug) should feel free to use MongoDB's builders or write their own; either would be an improvement over the status quo.

          julianhyde Julian Hyde added a comment - I don't intend to dissuade you from fixing this. You (or whoever wishes to fix this bug) should feel free to use MongoDB's builders or write their own; either would be an improvement over the status quo.

          People

            Unassigned Unassigned Assign to me
            dmsysolyatin Dmitry Sysolyatin

            Dates

              Created:
              Updated:

              Slack

                Issue deployment

                  Client must be authenticated to access this resource.