[CALCITE-6497] Use helper setup method throughout whole ElasticsearchAdapterTest

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.37.0
• Fix Version/s: 1.38.0
• Component/s: elasticsearch-adapter, tests
• Labels: pull-request-available
• Assignee: Tim Grein
• Reporter: Tim Grein
• Created: 24/Jul/24 12:59
• Updated: 17/Oct/24 22:41
• Resolved: 17/Oct/24 22:41

Description

There's a helper method `calciteAssert` inside the `ElasticsearchAdapterTest`, which is responsible for setting up a connection to Elasticsearch. This helper method is not used throughout the test class consistently, which leads to code duplication and some manual setup code. We should use the helper method to keep things consistent.

Issue Links

• links to: GitHub Pull Request #3881
• links to: GitHub Pull Request #3881