[CALCITE-6495] Allow ProjectSetOpTransposeRule to work with any subclass of Project

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.37.0
• Fix Version/s: 1.38.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Ruben Q L
• Reporter: Ruben Q L
• Created: 23/Jul/24 09:42
• Updated: 17/Oct/24 22:41
• Resolved: 17/Oct/24 22:41

Description

Even if the default configuration of ProjectSetOpTransposeRule matches a LogicalProject, theoretically any downstream project could adjust the rule config to match a different subclass of Project, with the corresponding RelBuilderFactory, to obtain the rule behavior customized for their needs.

However, at this point this cannot work because ProjectSetOpTransposeRule#onMatch performs a

final LogicalProject origProject = call.rel(0);

which leads to a ClassCastException in this scenario.

Therefore, this line should be changed (and generalized) into

final Project origProject = call.rel(0);

(as it happens already in other rules, such as FilterSetOpTransposeRule or ProjectFilterTransposeRule) to improve the rule's adaptability, without impacting the rule's behavior.

Issue Links

• links to: GitHub Pull Request #3880