Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-649

Extend splitCondition method in RelOptUtil to support MultiJoin operator

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Currently, we can only extract information from the condition of binary Join operators; the corresponding method in RelOptUtil should be generalized to support join with n inputs.

        Issue Links

          Activity

          Hide
          jcamachorodriguez Jesus Camacho Rodriguez added a comment -

          Julian Hyde, I have created a pull request for this, could you take a look? Thanks

          Show
          jcamachorodriguez Jesus Camacho Rodriguez added a comment - Julian Hyde , I have created a pull request for this, could you take a look? Thanks
          Hide
          julianhyde Julian Hyde added a comment -

          Looks good.

          The method returns "what's left" (i.e. the non-equi conditions). Can you explain how would work (or, if it works, whether it would be useful) in the n > 2 case.

          Show
          julianhyde Julian Hyde added a comment - Looks good. The method returns "what's left" (i.e. the non-equi conditions). Can you explain how would work (or, if it works, whether it would be useful) in the n > 2 case.
          Hide
          jcamachorodriguez Jesus Camacho Rodriguez added a comment -

          Julian Hyde, I used the same method interface that was used for binary join, but for multijoin. Thus, the behavior is the same that we had for binary joins; we return the conditions that are left. I don't know if that answers your question?

          Show
          jcamachorodriguez Jesus Camacho Rodriguez added a comment - Julian Hyde , I used the same method interface that was used for binary join, but for multijoin. Thus, the behavior is the same that we had for binary joins; we return the conditions that are left. I don't know if that answers your question?
          Hide
          julianhyde Julian Hyde added a comment -

          If it's an outer join you would need to know not just what conditions are left but also which pair (or pairs) of inputs the conditions came from.

          Show
          julianhyde Julian Hyde added a comment - If it's an outer join you would need to know not just what conditions are left but also which pair (or pairs) of inputs the conditions came from.
          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/61eea9ce .
          Hide
          julianhyde Julian Hyde added a comment -

          Resolved in release 1.2.0-incubating (2015-04-16)

          Show
          julianhyde Julian Hyde added a comment - Resolved in release 1.2.0-incubating (2015-04-16)

            People

            • Assignee:
              jcamachorodriguez Jesus Camacho Rodriguez
              Reporter:
              jcamachorodriguez Jesus Camacho Rodriguez
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development