[CALCITE-6434] JDBC adapter generates wrong SQL for Spark and Hive because it fails to quote an identifier containing '$'

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.37.0
• Fix Version/s: 1.38.0
• Component/s: core
• Labels: pull-request-available
• Assignee: xiong duan
• Reporter: xiong duan
• Created: 11/Jun/24 11:07
• Updated: 17/Oct/24 22:41
• Resolved: 17/Oct/24 22:41

Description

The SQL:

SELECT product.product_class_id C
FROM foodmart.product
LEFT JOIN (SELECT CASE COUNT(*) WHEN 0 THEN NULL WHEN 1 THEN MIN(product_class_id) ELSE (SELECT NULL
UNION ALL
SELECT NULL) END $f0
FROM foodmart.product) t0 ON TRUE
WHERE product.net_weight > t0.$f0

Generate by SINGLE_VALUE agg function.

This SQL will parse failed in Spark Unless we add the identifier quoting like `t0`.`$f0`

I will add identifier Quote String for Spark and Hive, Here is the document:

• https://spark.apache.org/docs/latest/sql-ref-identifier.html
• https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-hive.support.quoted.identifiers

Issue Links

• links to: GitHub Pull Request #3820