[CALCITE-6433] SUBSTRING can return incorrect empty result for some parameters

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.37.0
• Fix Version/s: 1.38.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Evgeny Stanilovsky
• Reporter: Iurii Gerzhedovich
• Created: 11/Jun/24 07:49
• Updated: 17/Oct/24 22:41
• Resolved: 17/Oct/24 22:41

Description

SUBSTRING function for cases when 3rd parameter (length) more than
Integer.MAX_VALUE can return empty result due to code do clamp
 that value and after that it can't be more than Integer.MAX_VALUE.
Simple way to reproduce :
append into SqlOperatorTest smth like:

    f.checkScalar(
        String.format("{fn SUBSTRING('abcdef', %d, %d)}", Integer.MIN_VALUE, 10L + Integer.MAX_VALUE),
        "abcdef",
        "VARCHAR(6) NOT NULL");

it`s all due to check after clamping

public static String substring(String c, int s, int l) {
  ....
  long e = (long) s + (long) l; -- here we can got incorrect length 
  .....
  if (s > lc || e < 1L) {
    return "";
  }
.....

 

 

Issue Links

• links to: GitHub Pull Request #3904