Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-641

Implement logging throughout Avatica server

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0-incubating
    • Component/s: None
    • Labels:

      Description

      Right now there's not much to go on regarding the Avatica internals. We should make a decision on a logging library and take a first pass at operational log messages. We should also provide a recommended log configuration for downstreamers.

        Issue Links

          Activity

          Hide
          julianhyde Julian Hyde added a comment -

          Agreed. My preference is low-dependency and flexible (Avatica might be used with and without Hadoop on the path, for instance).

          Note that JDBC is integrated with java.util.logging - see java.sql.Driver#getLogging - but that does not absolutely force our hand.

          Show
          julianhyde Julian Hyde added a comment - Agreed. My preference is low-dependency and flexible (Avatica might be used with and without Hadoop on the path, for instance). Note that JDBC is integrated with java.util.logging - see java.sql.Driver#getLogging - but that does not absolutely force our hand.
          Hide
          ndimiduk Nick Dimiduk added a comment -

          I think Hadoop projects tend to use Apache Commons Logging. I believe SLF4J may be the more current best-practice however, In particular, it has MDC support, which would be a good thing.

          Show
          ndimiduk Nick Dimiduk added a comment - I think Hadoop projects tend to use Apache Commons Logging. I believe SLF4J may be the more current best-practice however, In particular, it has MDC support, which would be a good thing.
          Hide
          julianhyde Julian Hyde added a comment -

          +1

          Show
          julianhyde Julian Hyde added a comment - +1
          Hide
          ndimiduk Nick Dimiduk added a comment -

          Adds some log statements to avatica-server components at INFO, DEBUG, and TRACE levels. Looking at this makes me wonder if remote.JsonHandler should have been moved to the avatica-server module as well.

          Show
          ndimiduk Nick Dimiduk added a comment - Adds some log statements to avatica-server components at INFO, DEBUG, and TRACE levels. Looking at this makes me wonder if remote.JsonHandler should have been moved to the avatica-server module as well.
          Hide
          julianhyde Julian Hyde added a comment -

          You might be right. But we might also want to break out a "transport". Then we'd want to put both ends of the transport into the same module.

          Show
          julianhyde Julian Hyde added a comment - You might be right. But we might also want to break out a "transport". Then we'd want to put both ends of the transport into the same module.
          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/d4d7ab99 .
          Hide
          julianhyde Julian Hyde added a comment -

          Resolved in release 1.2.0-incubating (2015-04-16)

          Show
          julianhyde Julian Hyde added a comment - Resolved in release 1.2.0-incubating (2015-04-16)

            People

            • Assignee:
              julianhyde Julian Hyde
              Reporter:
              ndimiduk Nick Dimiduk
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development