[CALCITE-6262] CURRENT_TIMESTAMP(P) ignores DataTypeSystem#getMaxPrecision

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.36.0
• Fix Version/s: 1.37.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Adam Kennedy
• Created: 12/Feb/24 21:32
• Updated: 06/May/24 22:19
• Resolved: 11/Mar/24 23:14

Description

Datetime precision parameters are incorrectly validated against the DEFAULT maximum date time precision (3) instead of against the maximum date time precision configured by the DateTimeSystem#getMaxPrecision method.

This breaks, at minimum, CURRENT_TIMESTAMP(P > 3) when precisions greater than 3 are supported by the system.

The culprit is the following method in SqlAbstractTimeFunction

 

@Override public RelDataType inferReturnType(SqlOperatorBinding opBinding) {
    // REVIEW jvs 20-Feb-2005: Need to take care of time zones.
    int precision = 0;
    if (opBinding.getOperandCount() == 1) {
        RelDataType type = opBinding.getOperandType(0);
        if (SqlTypeUtil.isNumeric(type)) {
            precision = getOperandLiteralValueOrThrow(opBinding, 0, Integer.class);
        }
    }
    assert precision >= 0;
    if (precision > SqlTypeName.MAX_DATETIME_PRECISION) {
        throw opBinding.newError(
            RESOURCE.argumentMustBeValidPrecision(
            opBinding.getOperator().getName(), 0,
            SqlTypeName.MAX_DATETIME_PRECISION));
    }
    return opBinding.getTypeFactory().createSqlType(typeName, precision);
}

 

 

The correct value is readily accessible from

 

opBinding.getTypeFactory().getTypeSystem().getMaxPrecision(typeName)

 

Issue Links

• links to: GitHub Pull Request #3697