Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-626

Provide means for Avatica statements to be close()'ed

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0-incubating
    • Component/s: None
    • Labels:

      Description

      Without this, statement objects build up on the server. Simple approach adds new RPC for this. Would be good to optimize such that closeOnCompletion such that the additional Rpc is not needed.

      1. CALCITE-626.00.patch
        7 kB
        Nick Dimiduk
      2. CALCITE-626.01.patch
        12 kB
        Nick Dimiduk
      3. CALCITE-626.02.patch
        14 kB
        Nick Dimiduk
      4. CALCITE-626.03.patch
        14 kB
        Nick Dimiduk

        Activity

        Hide
        julianhyde Julian Hyde added a comment -

        Resolved in release 1.2.0-incubating (2015-04-16)

        Show
        julianhyde Julian Hyde added a comment - Resolved in release 1.2.0-incubating (2015-04-16)
        Hide
        ndimiduk Nick Dimiduk added a comment -

        Thanks Julian Hyde!

        Show
        ndimiduk Nick Dimiduk added a comment - Thanks Julian Hyde !
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/208eda66 .
        Hide
        ndimiduk Nick Dimiduk added a comment -

        Yes, I think that's entirely reasonable. There's already the avatica-server module.

        Show
        ndimiduk Nick Dimiduk added a comment - Yes, I think that's entirely reasonable. There's already the avatica-server module.
        Hide
        julianhyde Julian Hyde added a comment -

        Is it worth moving the server-side bits of Avatica into a different module? I want the client-side or shared parts to stay lean. JdbcMeta would be a server-side piece, as would the connection/statement tables.

        Show
        julianhyde Julian Hyde added a comment - Is it worth moving the server-side bits of Avatica into a different module? I want the client-side or shared parts to stay lean. JdbcMeta would be a server-side piece, as would the connection/statement tables.
        Hide
        ndimiduk Nick Dimiduk added a comment -

        But would it be worth bringing in Guava (on the server side only) for its caches?

        That's what I've done on CALCITE-640.

        Show
        ndimiduk Nick Dimiduk added a comment - But would it be worth bringing in Guava (on the server side only) for its caches? That's what I've done on CALCITE-640 .
        Hide
        julianhyde Julian Hyde added a comment -

        As you know I am trying to keep dependencies to a minimum. But would it be worth bringing in Guava (on the server side only) for its caches? IIRC they handle timeout elegantly.

        Show
        julianhyde Julian Hyde added a comment - As you know I am trying to keep dependencies to a minimum. But would it be worth bringing in Guava (on the server side only) for its caches? IIRC they handle timeout elegantly.
        Hide
        julianhyde Julian Hyde added a comment -

        The messiness is all confined to one test. I'm not that concerned about it.

        Show
        julianhyde Julian Hyde added a comment - The messiness is all confined to one test. I'm not that concerned about it.
        Hide
        ndimiduk Nick Dimiduk added a comment -

        Rebased patch on to master (post 1.1). Still has the ugly reflection in test that reaches through abstractions and java package restrictions to verify remote state. Any suggestions for cleanup Julian Hyde?

        Show
        ndimiduk Nick Dimiduk added a comment - Rebased patch on to master (post 1.1). Still has the ugly reflection in test that reaches through abstractions and java package restrictions to verify remote state. Any suggestions for cleanup Julian Hyde ?
        Hide
        ndimiduk Nick Dimiduk added a comment -

        Closing up server-side resources as well. Includes terrifying test.

        Show
        ndimiduk Nick Dimiduk added a comment - Closing up server-side resources as well. Includes terrifying test.

          People

          • Assignee:
            julianhyde Julian Hyde
            Reporter:
            ndimiduk Nick Dimiduk
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development