[CALCITE-6190] Incorrect precision derivation for negative numeric types

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.36.0
• Fix Version/s: 1.37.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Mihai Budiu
• Reporter: Evgeny Stanilovsky
• Created: 05/Jan/24 07:37
• Updated: 06/May/24 22:19
• Resolved: 10/Jan/24 19:08

Description

Test highlights the problem :

  @Test void testTypeOfAs() {
    sql("select DECIMAL '100.01' as c1 from (values (true))")
        .columnType("DECIMAL(5, 2) NOT NULL");
    sql("select DECIMAL '-100.01' as c1 from (values (true))")
        .columnType("DECIMAL(5, 2) NOT NULL");
}

Throws exception for second expression:

Expected: is "DECIMAL(5, 2) NOT NULL"
     but: was "DECIMAL(6, 2) NOT NULL"

Seems root cause in SqlLiteral#createExactNumeric precision derivation not consider negative numbers.

Issue Links

• links to: GitHub Pull Request #3619