Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-618

Add Avatica support for getTables

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 1.2.0-incubating
        • Component/s: None
        • Labels:

          Description

          Per the title.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            julianhyde Julian Hyde added a comment -

            Needs a test.

            Show
            julianhyde Julian Hyde added a comment - Needs a test.
            Hide
            Permalink
            ndimiduk Nick Dimiduk added a comment -

            New patch adds a test. It's throwing NPE, which I don't see when running the code with my real client/server. Seems like Something in the test stack is putting a null for a Signature. Mind having a look?

            Show
            ndimiduk Nick Dimiduk added a comment - New patch adds a test. It's throwing NPE, which I don't see when running the code with my real client/server. Seems like Something in the test stack is putting a null for a Signature. Mind having a look?
            Hide
            Permalink
            julianhyde Julian Hyde added a comment -

            I've fixed the NPE. If the JSON result doesn't contain columns, Avatica now makes up the definitions by inspecting the fields of the metadata class, e.g. MetaTable.class.

            See https://github.com/julianhyde/incubator-calcite/commit/4d67bdeac5e7432efeb6989f21e43cea508913aa

            Show
            julianhyde Julian Hyde added a comment - I've fixed the NPE. If the JSON result doesn't contain columns, Avatica now makes up the definitions by inspecting the fields of the metadata class, e.g. MetaTable.class. See https://github.com/julianhyde/incubator-calcite/commit/4d67bdeac5e7432efeb6989f21e43cea508913aa
            Hide
            Permalink
            ndimiduk Nick Dimiduk added a comment -

            Your version of the patch (still) works for me!

            Show
            ndimiduk Nick Dimiduk added a comment - Your version of the patch (still) works for me!
            Hide
            Permalink
            julianhyde Julian Hyde added a comment -

            Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/4d2f647a.

            Show
            julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/4d2f647a .
            Hide
            Permalink
            julianhyde Julian Hyde added a comment -

            Resolved in release 1.2.0-incubating (2015-04-16)

            Show
            julianhyde Julian Hyde added a comment - Resolved in release 1.2.0-incubating (2015-04-16)

              People

              • Assignee:
                julianhyde Julian Hyde
                Reporter:
                ndimiduk Nick Dimiduk
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development