[CALCITE-6169] EnumUtils.convert does not implement the correct SQL cast semantics

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.36.0
• Fix Version/s: 1.38.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Mihai Budiu
• Created: 19/Dec/23 02:30
• Updated: 17/Oct/24 22:41
• Resolved: 17/Oct/24 22:41

Description

The code generated by EnumUtil for casts uses the Java semantics, where casts just truncate values. The SQL semantics requires a runtime exception if the value does not fit in the target datatype.

Some of the bugs in this code generator are masked by the BlockBuilder optimizer which attempts to optimize the generated code using the SQL semantics... But if the code is not optimized and is executed in Java it generates wrong results for most conversions that overflow.

One additional wrinkle is that it is not entirely clear whether the bug is in EnumUtils or in the code that invokes EnumUtils. It is not specified which of the two semantics for casts EnumUtils are supposed to implement: Java or SQL?

Issue Links

• is related to: CALCITE-6366 Code generated by EnumUtils#convert should throw an exception if the target type is overflowed
• links to: GitHub Pull Request #3764