[CALCITE-6100] The equalsDeep of SqlRowTypeNameSpec should use equalsDeep for fieldTypes rather than reference comparison

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.35.0, 1.36.0
• Fix Version/s: 1.37.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Dmitry Sysolyatin
• Reporter: Dmitry Sysolyatin
• Created: 09/Nov/23 19:32
• Updated: 06/May/24 22:19
• Resolved: 11/Nov/23 20:59

Description

SqlRowTypeNameSpec#equalsDeep method uses reference comparison for objects inside fieldTypes list instead of using SqlDataTypeSpec#equalsDeep.

Testcase: Add to `SqlEqualsDeepTest` the following lines of code:

@Test
void testRowEqualsDeep() throws SqlParseException {
assertEqualsDeep("CAST(a AS ROW(field INTEGER))",
"CAST(a AS ROW(field INTEGER))", true);
}

Issue Links

• links to: GitHub Pull Request #3512