[CALCITE-6071] RexCall should carry source position information for runtime error reporting

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.35.0
• Fix Version/s: 1.38.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Mihai Budiu
• Reporter: Mihai Budiu
• Created: 24/Oct/23 21:13
• Updated: 5 days ago 22:41
• Resolved: 5 days ago 22:41

Description

Currently runtime errors, such as division by zero, cannot report the position in the original source code where the original operator was. RexNode does not carry such information. By adding the required information in RexNode we can report much better runtime errors to users.

Here is an additional comment from jhyde on the dev mailing list:

The RexCall to such throwable functions would have a hidden ‘pos’ parameter. The parameter should be populated at Sql-to-rel time, and if it is not present, SqlOperator.validareRexOperands should throw. Associating the position with the particular function call seems to me much more robust than associating it with the RelNode that contains the call.
 

Issue Links

• blocks: CALCITE-6582 Release Calcite 1.38.0
• links to: GitHub Pull Request #3506