Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-605

Reduce dependency on third-party maven repositories

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Calcite's dependencies are spread among Apache repo, Maven central, and Conjars. All Apache dependencies should be (and I believe are) in Apache, and everything else should be in Maven central.

      Currently some dependencies are in Conjars:

      • eigenbase eigenbase-properties
      • net.hydromatic quidem
      • net.hydromatic tpcds
      • org.pentaho pentaho-aggdesigner-algorithm
      • pentaho mondrian-data-foodmart-hsqldb
      • pentaho mondrian-data-foodmart-queries
      • sqlline sqlline

      Move or copy these into Maven central.

        Issue Links

          Activity

          Hide
          leeyuiwah Yui-Wah Lee added a comment -

          Julian Hyde – Thanks for the good tip. And also for the good work on Calcite!

          Show
          leeyuiwah Yui-Wah Lee added a comment - Julian Hyde – Thanks for the good tip. And also for the good work on Calcite!
          Hide
          julianhyde Julian Hyde added a comment -

          Sorry that Hive has not caught up. Note that when Hive uses Calcite it doesn't use pentaho-aggdesigner-algorithm (either at compile time or at run time), so you can safely exclude that dependency. Also, if you don't want to set up a local repository, you can use the Conjars repository.

          Show
          julianhyde Julian Hyde added a comment - Sorry that Hive has not caught up. Note that when Hive uses Calcite it doesn't use pentaho-aggdesigner-algorithm (either at compile time or at run time), so you can safely exclude that dependency. Also, if you don't want to set up a local repository, you can use the Conjars repository.
          Hide
          leeyuiwah Yui-Wah Lee added a comment -

          Okay thanks!

          The latest hive-exec seems to be 2.3.0 (as of today 2017-10-19), which depends on calcite-core:1.10.0, and thus still transitively depends on org.pentaho:pentaho-aggdesigner-algorithm

          Also, our hive server is not yet 2.3.0, so we can't upgrade our hive client anyway. I guess we will have to wait (and, in the mean time, use another solution such as a local artifactory server). Thanks anyway!

          [INFO] +- org.apache.hive:hive-exec:jar:2.3.0:compile
          [INFO] |  +- ...
          [INFO] |  +- org.apache.calcite:calcite-core:jar:1.10.0:compile
          [INFO] |  |  +- ...
          [INFO] |  |  \- org.pentaho:pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde:compile
          
          Show
          leeyuiwah Yui-Wah Lee added a comment - Okay thanks! The latest hive-exec seems to be 2.3.0 (as of today 2017-10-19), which depends on calcite-core:1.10.0, and thus still transitively depends on org.pentaho:pentaho-aggdesigner-algorithm Also, our hive server is not yet 2.3.0, so we can't upgrade our hive client anyway. I guess we will have to wait (and, in the mean time, use another solution such as a local artifactory server). Thanks anyway! [INFO] +- org.apache.hive:hive-exec:jar:2.3.0:compile [INFO] | +- ... [INFO] | +- org.apache.calcite:calcite-core:jar:1.10.0:compile [INFO] | | +- ... [INFO] | | \- org.pentaho:pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde:compile
          Hide
          julianhyde Julian Hyde added a comment -

          That message means that pentaho-aggdesigner-algorithm was still a problem as of 1.2.0-incubating. We fixed it in CALCITE-1474 (release 1.11.0).

          1.2.0-incubating is a very old release (and, as an incubating release, not made under Apache foundation governance) so I strongly recommend upgrading as early as possible.

          Show
          julianhyde Julian Hyde added a comment - That message means that pentaho-aggdesigner-algorithm was still a problem as of 1.2.0-incubating. We fixed it in CALCITE-1474 (release 1.11.0). 1.2.0-incubating is a very old release (and, as an incubating release, not made under Apache foundation governance) so I strongly recommend upgrading as early as possible.
          Hide
          leeyuiwah Yui-Wah Lee added a comment -

          I am building a project that depends on calcite-core:1.2.0-incubating, and I still get this dependency and it leads to a problem of missing artifact of pentaho-aggdesigner-algorithm (I did not add conjars.org as one of my repos).

          159 [INFO] +- org.spark-project.hive:hive-exec:jar:1.2.1.spark2:compile
          160 [INFO] |  +- org.apache.calcite:calcite-core:jar:1.2.0-incubating:compile
          161 [INFO] |  |  \- org.pentaho:pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde:compile
          

          Is this expected? I think the message above (dated 23/Mar/2015) means the problem should have been fixed?

          Show
          leeyuiwah Yui-Wah Lee added a comment - I am building a project that depends on calcite-core:1.2.0-incubating, and I still get this dependency and it leads to a problem of missing artifact of pentaho-aggdesigner-algorithm (I did not add conjars.org as one of my repos). 159 [INFO] +- org.spark-project.hive:hive-exec:jar:1.2.1.spark2:compile 160 [INFO] | +- org.apache.calcite:calcite-core:jar:1.2.0-incubating:compile 161 [INFO] | | \- org.pentaho:pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde:compile Is this expected? I think the message above (dated 23/Mar/2015) means the problem should have been fixed?
          Hide
          julianhyde Julian Hyde added a comment -

          Closing now that 1.1.0-incubating has been released.

          Show
          julianhyde Julian Hyde added a comment - Closing now that 1.1.0-incubating has been released.
          Hide
          julianhyde Julian Hyde added a comment -

          Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/3eb6515d.

          We have removed the dependency on conjars to maven plugins.

          One dependency remains in conjars: pentaho-aggdesigner-algorithm. Still working on that one, and hopefully we can remove soon.

          Show
          julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/3eb6515d . We have removed the dependency on conjars to maven plugins. One dependency remains in conjars: pentaho-aggdesigner-algorithm. Still working on that one, and hopefully we can remove soon.
          Hide
          julianhyde Julian Hyde added a comment -

          I've fixed most of the above by moving them into maven central using the net.hydromatic as groupId in https://github.com/julianhyde/incubator-calcite/tree/calcite-605. Just sqlline and pentaho-aggdesigner-algorithm remain.

          Show
          julianhyde Julian Hyde added a comment - I've fixed most of the above by moving them into maven central using the net.hydromatic as groupId in https://github.com/julianhyde/incubator-calcite/tree/calcite-605 . Just sqlline and pentaho-aggdesigner-algorithm remain.
          Hide
          julianhyde Julian Hyde added a comment -

          Also:

          • net.hydromatic hydromatic-resource-maven-plugin

          I have opened https://issues.sonatype.org/browse/OSSRH-14224 for net.hydromatic.

          Show
          julianhyde Julian Hyde added a comment - Also: net.hydromatic hydromatic-resource-maven-plugin I have opened https://issues.sonatype.org/browse/OSSRH-14224 for net.hydromatic.

            People

            • Assignee:
              julianhyde Julian Hyde
              Reporter:
              julianhyde Julian Hyde
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development