[CALCITE-6013] RelBuilder should simplify plan by pruning unused measures

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.36.0
• Labels: pull-request-available
• Assignee: Tanner Clary
• Reporter: Tanner Clary
• Created: 18/Sep/23 17:20
• Updated: 23/Jul/24 00:57
• Resolved: 24/Oct/23 21:18

Description

If you have a test like the following (modified from SqlToRelConverterTest#testMeasureRef)

    final String sql = "select deptno as c\n"
        + "from empm\n"
        + "group by deptno";
    fixture()
        .withFactory(c ->
            c.withOperatorTable(t ->
                SqlValidatorTest.operatorTableFor(SqlLibrary.CALCITE)))
        .withCatalogReader(MockCatalogReaderExtended::create)
        .withSql(sql)
        .ok();

The expected results should look something like:

LogicalAggregate(group=[{0}])
  LogicalProject(C=[$7])
    LogicalTableScan(table=[[CATALOG, SALES, EMPM]])

Instead it looks like:

LogicalAggregate(group=[{0}])
  LogicalProject(C=[$7], COUNT_PLUS_100=[$9], COUNT_TIMES_100=[$10])
    LogicalTableScan(table=[[CATALOG, SALES, EMPM]])

I believe this is due to commit 568ce12.

In essence, the measures should not be added to the projects unless necessary.

Issue Links

• is related to: CALCITE-4496 Measure columns ("SELECT ... AS MEASURE")
• links to: GitHub Pull Request #3434