Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      It is under org.apache.calcite.rel.rules, while the right package is org.apache.calcite.rel.core.

        Activity

        Hide
        julianhyde Julian Hyde added a comment -

        Closing now that 1.1.0-incubating has been released.

        Show
        julianhyde Julian Hyde added a comment - Closing now that 1.1.0-incubating has been released.
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/c493108d .
        Hide
        jcamachorodriguez Jesus Camacho Rodriguez added a comment -

        Julian Hyde, thanks for the feedback. I have just updated the pull request

        Show
        jcamachorodriguez Jesus Camacho Rodriguez added a comment - Julian Hyde , thanks for the feedback. I have just updated the pull request
        Hide
        julianhyde Julian Hyde added a comment -

        Since 1.0 we are being conservative about breaking changes. I think you should move EquiJoin to core but leave a trivial sub-class in rules, and mark it '@Deprecated // to be removed before 2.0'. And of course fix all code in Calcite to use the newer version.

        Show
        julianhyde Julian Hyde added a comment - Since 1.0 we are being conservative about breaking changes. I think you should move EquiJoin to core but leave a trivial sub-class in rules, and mark it '@Deprecated // to be removed before 2.0'. And of course fix all code in Calcite to use the newer version.

          People

          • Assignee:
            jcamachorodriguez Jesus Camacho Rodriguez
            Reporter:
            jcamachorodriguez Jesus Camacho Rodriguez
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development