Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-593

Validator in Frameworks should expand identifiers

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Calcite supports two ways to build query plan for a SQL statement. Either submit the query through JDBC, which will use CalcitePrepareImpl class, or build a customized planner by leveraging the Frameworks/PlannerImpl class. However, the SqlValidator created in Frameworks/PlannerImpl uses a different setting in terms of identifier expanding, than the setting in the SqlValidator in CalcitePrepareImpl. This implies that one same query goes through those two SqlValidators would have different validated forms.

      SqlValidator.expandIdentifiers in by default is set to false. But CalcitePrepareImpl.prepare() will reset it to true at CalcitePrepareImpl:494:

            final SqlValidator validator =
                new CalciteSqlValidator(opTab, catalogReader, typeFactory);
            validator.setIdentifierExpansion(true);
      

      In contrast, the SqlValidator created in Frameworks/PlannerImpl will still use the default "false" setting.

      Further, Frameworks does not expose the instance of SqlValidator, so user does not have a way to change the setting for the SqlValidator created in Frameworks/PlannerImpl.

      To make behaviors consistent, I would like to propose that we make Framework's SqlValidator uses the same setting as the one in CalcitePrepareImpl.

        Attachments

          Activity

            People

            • Assignee:
              julianhyde Julian Hyde
              Reporter:
              jni Jinfeng Ni
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: