[CALCITE-5908] Refactor: Remove unnecessary null checks in CalciteSchema

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.35.0
• Fix Version/s: 1.36.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Ran Tao
• Reporter: Ran Tao
• Created: 08/Aug/23 15:26
• Updated: 10/Nov/23 11:34
• Resolved: 12/Aug/23 00:50

Description

When i read the source code of `CalciteSchema` found so many null checks below:

 

    if (tableMap == null) {
      this.tableMap = new NameMap<>();
    } else {
      this.tableMap = Objects.requireNonNull(tableMap, "tableMap");
    }
    if (latticeMap == null) {
      this.latticeMap = new NameMap<>();
    } else {
      this.latticeMap = Objects.requireNonNull(latticeMap, "latticeMap");
    } 

i think we can remove it. it was misleading.

 

Issue Links

• links to: GitHub Pull Request #3358