[CALCITE-5865] ClassCastException with FLOOR and CEIL on conformances that are not builtin

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 1.35.0
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Gian Merlino
• Created: 19/Jul/23 23:19
• Updated: 27/Jul/23 10:22
• Resolved: 20/Jul/23 17:39

Description

CALCITE-5747 introduced some BigQuery-specific logic for FLOOR and CEIL that is keyed off the conformance being SqlConformanceEnum.BIG_QUERY. However, it was implemented in such a way that implementations of SqlConformance that are not SqlConformanceEnum would throw ClassCastException, due to this line in Parser.jj:

SqlOperator op = SqlStdOperatorTable.floorCeil(floorFlag, (SqlConformanceEnum) this.conformance);

Better would be to pass this.conformance without casting, and adjust SqlStdOperatorTable.floorCeil to handle any kind of conformance.

This affects us in Apache Druid land, because we have a conformance that extends SqlAbstractConformance.

Issue Links

• is caused by: CALCITE-5747 Conflicting FLOOR return type between Calcite and BigQuery
• links to: GitHub Pull Request #3327
• links to: GitHub Pull Request #3332