[CALCITE-5823] Remove commons-collections dependency from innodb

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.34.0
• Fix Version/s: 1.35.0
• Component/s: innodb-adapter
• Labels: pull-request-available
• Assignee: Ran Tao
• Reporter: Ran Tao
• Created: 09/Jul/23 06:55
• Updated: 27/Jul/23 10:22
• Resolved: 09/Jul/23 23:17

Description

Currently,  CollectionsUtils is only used in a few places in the InnoDb adapter, and the only methods used are isEmpty and isNotEmpty. 

The only difference between CollectionUtils.isEmpty and list.isEmpty is the behavior if list is null. Modern coding practices would ensure that list is not null unless specified in its type.

So we can safely remove it to avoid using an entire library just for the sake of using isEmpty.

Issue Links

• is related to: CALCITE-5819 Upgrade commons-collections from 3.x to 4.4
• links to: GitHub Pull Request #3301