[CALCITE-5810] SUBSTRING compile-time evaluation gives wrong result for large lengths

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.34.0
• Fix Version/s: 1.35.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Mihai Budiu
• Reporter: Mihai Budiu
• Created: 29/Jun/23 03:55
• Updated: 27/Jul/23 10:22
• Resolved: 30/Jun/23 16:07

Description

This program

SELECT SUBSTRING('string' FROM 2 FOR 2147483646) 

returns "" instead of "tring".
This happens because of an overflow in the SqlFunctions substring function:

public static String substring(String c, int s, int l) {
    int lc = c.length();
    int e = s + l;  // <<<< OVERFLOW here

Issue Links

• links to: GitHub Pull Request #3286