[CALCITE-5726] Canonize use of Hamcrest matchers in test code

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.35.0
• Assignee: Julian Hyde
• Reporter: Julian Hyde
• Created: 26/May/23 18:39
• Updated: 27/Jul/23 10:22
• Resolved: 29/May/23 21:23

Description

Canonize use of Hamcrest matchers in test code.

1. If there are multiple equivalent methods, use the canonical one. Examples:

• Is.is → CoreMatchers.is
• HasToString.hasToString → Matchers.hasToString
• IsCollectionWithSize.hasSize → Matchers.hasSize
• IsMapWithSize.aMapWithSize → Matchers.aMapWithSize

2. Use matchers for Object.toString(), Collection.size(), Map.size():

• assertThat(map.size(), is(n)) → assertThat(map, aMapWithSize(n));
• assertThat(list.size(), is(n)) → assertThat(map, IsCollectionWithSize.hasSize(n));
• assertThat(o.toString(), is(s)) → assertThat(o, hasToString(s));
• assertThat(o.toString(), equalTo(s)) → assertThat(o, hasToString(s));

Require static import of Hamcrest methods.
 
The benefit is conciseness/uniformity of tests. Most of these transformations can be accomplished using autostyle rules in the Gradle build.gradle.kts, so people's code will be fixed using gradle autostyleApply.

Issue Links

• links to: dev branch