[CALCITE-5722] Sarg.isComplementedPoints fails with anti-points which are equal under `compareTo` but not `equals`

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.34.0
• Fix Version/s: 1.35.0
• Labels: pull-request-available
• Assignee: Ian Bertolacci
• Reporter: Ian Bertolacci
• Created: 24/May/23 18:54
• Updated: 27/Jul/23 10:22
• Resolved: 02/Jun/23 19:19

Description

Example:

final Sarg<BigDecimal> badComplimentPointsSarg =
  Sarg.of(
    RexUnknownAs.UNKNOWN,
    TreeRangeSet.create(
      Arrays.asList(
        // Create anti-point around 1, with different scales
        Range.lessThan(new BigDecimal("1")),
        Range.greaterThan(new BigDecimal("1.00000000000"))
      )
    )
  );
assertThat(badComplimentPointsSarg.isComplementedPoints(), is(true));

will fail.

This is because RangeSets.isPoints uses direct equality and not `Comparable.compareTo` equality

The values `1` and `1.00000000000` are not equal under `BigDecimal.equals` but are equal under `BigDecimal.compareTo`.

Issue Links

• links to: GitHub Pull Request #3224