[CALCITE-5650] Obtain typesystem from dialect in RelToSqlConverterTest

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.34.0
• Fix Version/s: 1.35.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Mihai Budiu
• Reporter: Mihai Budiu
• Created: 15/Apr/23 00:58
• Updated: 27/Jul/23 10:22
• Resolved: 19/Apr/23 12:16

Description

The problem is in the file SqlToRelConverterTest.java, in the static class Sql, in the following method:

    Sql dialect(SqlDialect dialect)

{       return new Sql(schemaSpec, sql, dialect, parserConfig, librarySet, config,           relFn, transforms, typeSystem);     }

The problem is that the dialect may have a different type system, which is ignored in this function. I think the function should read:

    Sql dialect(SqlDialect dialect)

{       return new Sql(schemaSpec, sql, dialect, parserConfig, librarySet, config,           relFn, transforms, dialect.getTypeSystem());     }

Several tests in this file do change the dialect type system.

Issue Links

• blocks: CALCITE-5651 Type system decimal scale in inferred types may exceed allowed scale
• is related to: CALCITE-4706 JDBC adapter generates casts exceeding Redshift's data types bounds
• links to: GitHub Pull Request #3155