[CALCITE-5647] RelMdPopulationSize should use mq.getRowCount(rel) instead of rel.estimateRowCount(mq)

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.34.0
• Fix Version/s: 1.37.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Adam Kennedy
• Reporter: Adam Kennedy
• Created: 14/Apr/23 21:56
• Updated: 06/May/24 22:19
• Resolved: 07/Feb/24 08:33

Description

A few locations in Calcite call rel.estimateRowCount(mq) when they should instead call mq.getRowCount(red).

We detected this because we implemented row count estimation entirely within an alternative handle instead of RelMdRowCount, and then override estimateRowCount to ensure the custom handler is user, by throwing an unreachable code exception.

A few places in Calcite trigger these unreachable exceptions because they do not use mq.getRowCount.

The most easily triggered on is in RelMdPopulationSize for the Values parameter.

Issue Links

• is related to: CALCITE-6249 RelNode::estimatedRowCount should not be used in computeSelfCost
• links to: GitHub Pull Request #3151
• links to: GitHub Pull Request #3632