Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-5571

Remove org.jetbrains.annotations from java source code

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.33.0
    • 1.35.0
    • None

    Description

      In the most part we are using checkerframework annotations (org.checkerframework.checker.nullness.qual) for specifying nullability. There are 2 places, namely ScannableTableTest and UtilTest where we have nullability annotations from org.jetbrains.annotations package.

      To keep things consistent and also avoid mixing up annotations from different providers in the future, I propose to remove the last references to org.jetbrains.annotations and exclude the org.jetbrains:annotations dependency from the build to avoid accidentally using such annotations in the future.

      Attachments

        Issue Links

          Activity

            People

              zabetak Stamatis Zampetakis
              zabetak Stamatis Zampetakis
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m