[CALCITE-557] Remove AbstractConverter

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.0-incubating
• Assignee: Julian Hyde
• Reporter: Julian Hyde
• Created: 13/Jan/15 20:18
• Updated: 08/Feb/15 08:56
• Resolved: 14/Jan/15 00:10

Description

Currently each subset contains an AbstractConverter to each subset in the same set. If there are a lot of active traits, there are many, many AbstractConverters that do not add anything to the planning.

This task would remove those AbstractConverters. In fact AbstractConverter would never be created.

Also, make costing of joins more deterministic when both inputs have the same number of rows. Currently we use the RelNode.id of the inputs, but this is unstable if we change what rules are activated. So, we should order the inputs based on the number of columns first, and on id only if that fails.