Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Currently each subset contains an AbstractConverter to each subset in the same set. If there are a lot of active traits, there are many, many AbstractConverters that do not add anything to the planning.

      This task would remove those AbstractConverters. In fact AbstractConverter would never be created.

      Also, make costing of joins more deterministic when both inputs have the same number of rows. Currently we use the RelNode.id of the inputs, but this is unstable if we change what rules are activated. So, we should order the inputs based on the number of columns first, and on id only if that fails.

        Activity

        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/506c1ab4 .
        Hide
        vladimirsitnikov Vladimir Sitnikov added a comment -

        Julian Hyde, you've just updated RuleMatchImportanceComparator to compare by rule class name first.
        Why is that?
        If that is intentional, I suppose some comment should be added / javadoc updated.

        Show
        vladimirsitnikov Vladimir Sitnikov added a comment - Julian Hyde , you've just updated RuleMatchImportanceComparator to compare by rule class name first. Why is that? If that is intentional, I suppose some comment should be added / javadoc updated.
        Hide
        julianhyde Julian Hyde added a comment -

        My mistake. I should have compared using importance first, rule class name second, and arguments (relational expressions) third. I wanted to make the comparison (more) deterministic in the case that two rules had identical arguments. I'll fix it.

        Show
        julianhyde Julian Hyde added a comment - My mistake. I should have compared using importance first, rule class name second, and arguments (relational expressions) third. I wanted to make the comparison (more) deterministic in the case that two rules had identical arguments. I'll fix it.
        Show
        julianhyde Julian Hyde added a comment - Fixed in http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/0c052cc6 .
        Hide
        julianhyde Julian Hyde added a comment -

        Closing now that 1.0.0-incubating has been released.

        Show
        julianhyde Julian Hyde added a comment - Closing now that 1.0.0-incubating has been released.

          People

          • Assignee:
            julianhyde Julian Hyde
            Reporter:
            julianhyde Julian Hyde
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development