[CALCITE-5510] RelToSqlConverter should use ordinal for ORDER BY if the dialect allows

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.26.0
• Fix Version/s: 1.34.0
• Component/s: core
• Labels: pull-request-available
• Assignee: peng wang
• Reporter: peng wang
• Created: 31/Jan/23 09:04
• Updated: 18/Apr/23 07:20
• Resolved: 25/Feb/23 10:10

Description

For example:
Query SQL is 

select a, sum(b) from table group by a order by 2

When we convert this sql to relNode and convert it back to SQL by RelToConverter, the result is:

select a, sum(b) from table group by a order by sum(b)

But we want to keep order by column to ordinal.

Would we add a switch in RelToConverter to control whether convert sort by column to expression or ordinal?
Maybe we can use method isSortByOrdinal in dialect SqlConformance?

Issue Links

• Testing discovered: CALCITE-5537 Slow test case failures in LatticeSuggesterTest
• links to: GitHub Pull Request #3057