[CALCITE-5489] When creating a RexCall to TIMESTAMP_DIFF function, cannot convert a TIMESTAMP literal to a org.apache.calcite.avatica.util.TimeUnit

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 1.33.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Tanner Clary
• Reporter: Sergey Nuyanzin
• Created: 23/Jan/23 00:49
• Updated: 07/Feb/23 22:33
• Resolved: 27/Jan/23 00:56

Description

It seems it stops working after

[CALCITE-5360] Add TIMESTAMP_ADD function (enabled in BigQuery library)

for RexCallBinding

e.g. this test starts failing

  @Test void testTimestampDiffCall() {
    final RelDataTypeFactory typeFactory = new SqlTypeFactoryImpl(RelDataTypeSystem.DEFAULT);
    RexBuilder rexBuilder = new RexBuilder(typeFactory);
    final RexImplicationCheckerFixtures.Fixture f = new RexImplicationCheckerFixtures.Fixture();
    final TimestampString ts =
        TimestampString.fromCalendarFields(Util.calendar());

    rexBuilder.makeCall(SqlStdOperatorTable.TIMESTAMP_DIFF,
        ImmutableList.of(rexBuilder.makeFlag(TimeUnit.QUARTER),
            f.timestampLiteral(ts), f.timestampLiteral(ts)));
  }

like

cannot convert TIMESTAMP literal to class org.apache.calcite.avatica.util.TimeUnit
java.lang.AssertionError: cannot convert TIMESTAMP literal to class org.apache.calcite.avatica.util.TimeUnit
	at org.apache.calcite.rex.RexLiteral.getValueAs(RexLiteral.java:1143)
	at org.apache.calcite.rex.RexCallBinding.getOperandLiteralValue(RexCallBinding.java:100)
	at org.apache.calcite.sql.fun.SqlTimestampDiffFunction.inferReturnType2(SqlTimestampDiffFunction.java:69)
	at org.apache.calcite.sql.SqlOperator.inferReturnType(SqlOperator.java:537)
	at org.apache.calcite.rex.RexBuilder.deriveReturnType(RexBuilder.java:292)
	at org.apache.calcite.rex.RexBuilder.makeCall(RexBuilder.java:266)
	at org.apache.calcite.rex.RexBuilderTest.testTimestampDiffCall(RexBuilderTest.java:863)
...

It seems it recognise FLAG(QUARTER) as a literal...
at org.apache.calcite.sql.fun.SqlTimestampDiffFunction#inferReturnType2

    if (opBinding.isOperandLiteral(0, true)) {
      type1 = opBinding.getOperandType(0);
      type2 = opBinding.getOperandType(1);
      timeUnit = opBinding.getOperandLiteralValue(2, TimeUnit.class);
    } else {
      timeUnit = opBinding.getOperandLiteralValue(0, TimeUnit.class);
      type1 = opBinding.getOperandType(1);
      type2 = opBinding.getOperandType(2);
    }

Issue Links

• relates to: CALCITE-5360 Implement TIMESTAMP_ADD function (compatible with BigQuery)
• links to: GitHub Pull Request #3040
• links to: GitHub Pull Request #3048