Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-5479

FamilyOperandTypeChecker is not readily composable in sequences

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.35.0
    • None

    Description

      Handling for OperandTypes.sequence changed in 33f4ab40bbee26e06209061c35a422f2f1e05371 such that iFormalOperand passed to subcheckers is no longer always zero, but is instead:

      • Zero if the subchecker is FamilyOperandTypeChecker.
      • Otherwise, the operand number in the overall sequence.

      It causes problems for the way we're using sequence checkers in Druid, since we don't always use FamilyOperandTypeChecker, but we do assume the old behavior: that iFormalOperand is always zero, and therefore we can put any checker into the sequence without it being "aware" that it is in a sequence.

      I marked this as a bug in case this change was made accidentally. If it was made for a reason, please let me know. Thanks.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              gian Gian Merlino
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 50m
                  50m