[CALCITE-5414] Use DateTimeUtils to correctly convert between java.sql types and Unix timestamps

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.32.0
• Fix Version/s: 1.33.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Gregory Hart
• Reporter: Gregory Hart
• Created: 02/Dec/22 01:16
• Updated: 28/Apr/23 23:55
• Resolved: 22/Jan/23 03:02

Description

Converting java.sql types to unix timestamps requires extra steps to also convert to the correct calendar. Unix timestamps should follow the proleptic Gregorian calendar as defined by ISO-8601. Java uses the standard Gregorian calendar for java.sql types and switches to the Julian calendar for dates before the Gregorian shift.

The DateTimeUtils class in Avatica correctly handles the calendar conversions. Calcite should use those methods since its own methods do not currently convert between calendars.

Issue Links

• depends upon: CALCITE-2989 Use ISO-8601 calendar when converting between java.sql types and UNIX timestamps
• depends upon: CALCITE-5480 Release Avatica 1.23.0
• is related to: CALCITE-5341 Upgrade Calcite to Avatica 1.23.0
• relates to: CALCITE-5678 Calcite should reject date literals not satisfying Gregorian calendar, per SQL standard
• links to: GitHub Pull Request #2995