[CALCITE-5377] RelFieldTrimmer support Sort with dynamic param

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.32.0
• Fix Version/s: 1.33.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Jiajun Xie
• Reporter: YUAN
• Created: 11/Nov/22 06:40
• Updated: 07/Feb/23 22:33
• Resolved: 25/Nov/22 09:06

Description

If Sort rel node used dynamic param, RelFieldTrimmer can not trim fields as expected.

The behavior makes ProjectableFilterableTable can not get correct projects.

Related code:

// org.apache.calcite.sql2rel.RelFieldTrimmer#trimFields(org.apache.calcite.rel.core.Sort, org.apache.calcite.util.ImmutableBitSet, java.util.Set<org.apache.calcite.rel.type.RelDataTypeField>)
// leave the Sort unchanged in case we have dynamic limits
if (sort.offset instanceof RexDynamicParam
    || sort.fetch instanceof RexDynamicParam) {
  return result(sort, inputMapping);
} 

I think we can support dynamic param without breaking anything.

Issue Links

• relates to: IGNITE-18311 AssertionError in SQL on subquery with offset and limit
• links to: GitHub Pull Request #2967