Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-527

Drop rowType field and constructor/copy argument of Calc

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 1.0.0-incubating
        • Fix Version/s: 1.0.0-incubating
        • Component/s: None
        • Labels:

          Description

          rowType can always be derived from the program.
          It does not make sense to have it as additional argument.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            julianhyde Julian Hyde added a comment -

            Yes, but make sure that the creator of the calc can set the output field names that they want. Meaningful field names make it a lot easier to understand plans and to debug.

            Show
            julianhyde Julian Hyde added a comment - Yes, but make sure that the creator of the calc can set the output field names that they want. Meaningful field names make it a lot easier to understand plans and to debug.
            Hide
            Permalink
            vladimirsitnikov Vladimir Sitnikov added a comment -

            That is important.
            As far as I can see:
            1) Column names can be defined when creating a program
            2) Calc.copy does not include rowType parameter

            So I guess it is rather safe to drop rowType from Calc constructor.

            Show
            vladimirsitnikov Vladimir Sitnikov added a comment - That is important. As far as I can see: 1) Column names can be defined when creating a program 2) Calc.copy does not include rowType parameter So I guess it is rather safe to drop rowType from Calc constructor.
            Hide
            Permalink
            vladimirsitnikov Vladimir Sitnikov added a comment -

            Fixed in https://git-wip-us.apache.org/repos/asf?p=incubator-calcite.git;a=commitdiff;h=076ac11a8b8eddb3200f199051414421db7fbdad

            Show
            vladimirsitnikov Vladimir Sitnikov added a comment - Fixed in https://git-wip-us.apache.org/repos/asf?p=incubator-calcite.git;a=commitdiff;h=076ac11a8b8eddb3200f199051414421db7fbdad
            Hide
            Permalink
            julianhyde Julian Hyde added a comment -

            Closing now that 1.0.0-incubating has been released.

            Show
            julianhyde Julian Hyde added a comment - Closing now that 1.0.0-incubating has been released.

              People

              • Assignee:
                julianhyde Julian Hyde
                Reporter:
                vladimirsitnikov Vladimir Sitnikov
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development