[CALCITE-5265] JDBC adapter sometimes adds unnecessary parentheses around SELECT in INSERT

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 1.33.0
• Labels: pull-request-available
• Assignee: Mou Wu
• Reporter: Mou Wu
• Created: 05/Sep/22 02:47
• Updated: 07/Feb/23 22:33
• Resolved: 29/Sep/22 13:18

Description

Add a case in RelToSqlConverterTest:

// code placeholder
@Test void testInsertValueWithDynamicParams() {
  final String sql = "insert into \"DEPT\" values (?,?,?)";
  final String expected = ""
      + "INSERT INTO \"SCOTT\".\"DEPT\" (\"DEPTNO\", \"DNAME\", \"LOC\")\n"
      + "SELECT ? AS \"DEPTNO\", ? AS \"DNAME\", ? AS \"LOC\"\n"
      + "FROM (VALUES (0)) AS \"t\" (\"ZERO\")";
  sql(sql)
      .schema(CalciteAssert.SchemaSpec.JDBC_SCOTT)
      .ok(expected);
}

will fail, because actual sql is with parentheses, maybe it's all right with parentheses, but the behavior is different from Union operator, you can see testInsertValuesWithDynamicParams in RelToSqlConverterTest class.

Issue Links

• links to: GitHub Pull Request #2910