[CALCITE-525] Exception-handling in built-in functions

• Type: Bug
• Status: In Progress
• Priority: Major
• Resolution: Unresolved
• Labels: pull-request-available
• Assignee: Hongze Zhang
• Reporter: Julian Hyde
• Created: 11/Dec/14 20:57
• Updated: 27/Feb/19 23:58

Description

The standard calls for certain built-in functions to throw exceptions.

Examples:

• 1 / 0
• MOD(1, 0)
• OVERLAY('foo' PLACING 'x' FROM -1)
• 'x' NOT LIKE 'x' ESCAPE 'x'

First, these exceptions should occur at run time. They should cause the current value to become null, or the row to be omitted, but should not abort the query. (Actual behavior TBD.)

Second, EnumerableCalc does constant reduction and generates code like 'static final int X = 0 / 0'. This code blows up when the class is loaded. It should not. The code should give errors for each row, as described above.

While fixing this bug, see SqlOperatorBaseTest.testArgumentBounds and remove restrictions related to /, MOD and OVERLAY, LIKE.

Issue Links

• is related to: CALCITE-2535 Runtime failure check not working in SqlTesterImpl.java
• links to: GitHub Pull Request #881
• links to: Pull request