[CALCITE-5166] Method accept(RelShuttle) is not overridden in LogicalCalc and LogicalTableModify

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.30.0
• Fix Version/s: 1.31.0
• Component/s: core
• Labels: pull-request-available pull_request_available
• Assignee: Roman Kondakov
• Reporter: Roman Kondakov
• Created: 22/May/22 15:18
• Updated: 03/Aug/22 16:21
• Resolved: 26/May/22 01:19

Description

Method RelNode#accept(RelShuttle) is not overridden for LogicalCalc and LogicalTableModify. This leads to the bug when logic implemented in RelShuttle#visit(LogicalCalc) is never applied because visit() method is never called due to incorrect dispatching.

This test will fail without accept(RelShuttle) method is overridden in Calc:

@Test void testRelShuttleForLogicalCalc() {
  final String sql = "select ename from emp";
  final RelNode rel = sql(sql).toRel();
  final HepProgramBuilder programBuilder = HepProgram.builder();
  programBuilder.addRuleInstance(CoreRules.PROJECT_TO_CALC);
  final HepPlanner planner = new HepPlanner(programBuilder.build());
  planner.setRoot(rel);
  final RelNode calc = planner.findBestExp();
  final List<RelNode> rels = new ArrayList<>();
  final RelShuttleImpl visitor = new RelShuttleImpl() {
    @Override public RelNode visit(LogicalCalc calc) {
      RelNode visitedRel = super.visit(calc);
      rels.add(visitedRel);
      return visitedRel;
    }
  };
  calc.accept(visitor);
  assertThat(rels.size(), is(1));
  assertThat(rels.get(0), isA(LogicalCalc.class));
} 

Issue Links

• is caused by: CALCITE-3607 Support LogicalTableModify in RelShuttle
• is caused by: CALCITE-3938 Support LogicalCalc in RelShuttle
• links to: GitHub Pull Request #2815