[CALCITE-5120] UnregisteredDriver#connect should throw SQLException, not NullPointerException, if url is null

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: avatica-1.20.0
• Fix Version/s: avatica-1.23.0
• Component/s: avatica
• Labels: pull-request-available
• Assignee: Dan Zou
• Reporter: Gregory Hart
• Created: 27/Apr/22 17:40
• Updated: 19/Jan/23 21:57
• Resolved: 10/Jan/23 12:51

Description

The documentation for java.sql.Driver#connect states that a SQLException should be thrown "if a database access error occurs or the url is null." However, UnregisteredDriver throws a NullPointerException instead.

Steps to reproduce:

new org.apache.calcite.avatica.remote.Driver().connect(null, new Properties());

Expected result:

A SQLException is thrown

Actual result:

A NullPointerException is thrown

java.lang.NullPointerException
    at org.apache.calcite.avatica.UnregisteredDriver.acceptsURL(UnregisteredDriver.java:144)
    at org.apache.calcite.avatica.UnregisteredDriver.connect(UnregisteredDriver.java:130)

Issue Links

• links to: GitHub Pull Request #204