[CALCITE-5061] Improve recursive application of the field trimming

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.31.0
• Labels: pull-request-available
• Assignee: Ruben Q L
• Reporter: Thomas Rebele
• Created: 23/Mar/22 15:04
• Updated: 03/Aug/22 16:21
• Resolved: 18/May/22 09:21

Description

The RelFieldTrimmer has some shortcomings:

• If the plan contains certain set ops (e.g., UNION(all=false)), even if the operator needs all fields for the correct result (CALCITE-3399), it may still make sense to apply the trimming to the children. See CALCITE-5051 for an example.
• Same applies for a Sort with dynamic parameters in the fetch/offset, and RepeatUnions
• The makeZeroLiteral logic in trimChildRestore(...) does not work for ARRAY / Java types.

Issue Links

• relates to: CALCITE-5051 UNION query plan prevents projection push down
• links to: GitHub Pull Request #2806
• links to: GitHub Pull Request #2812