[CALCITE-5040] SqlTypeFactoryTest.testUnknownCreateWithNullabilityTypeConsistency fails

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Resolved
• Fix Version/s: 1.30.0
• Labels: pull-request-available
• Assignee: Julian Hyde
• Reporter: Stamatis Zampetakis
• Created: 14/Mar/22 14:05
• Updated: 19/Mar/22 09:13
• Resolved: 16/Mar/22 01:42

Description

When run during the build (./gradlew clean build) the test fails intermittently but when it is executed individually it always fails.

./gradlew cleanTest :core:test --tests SqlTypeFactoryTest.testUnknownCreateWithNullabilityTypeConsistency

Stacktrace

java.lang.AssertionError: 
Expected: is an instance of org.apache.calcite.sql.type.SqlTypeFactoryImpl$UnknownSqlType
     but: <UNKNOWN> is a org.apache.calcite.sql.type.BasicSqlType
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
	at org.apache.calcite.sql.type.SqlTypeFactoryTest.testUnknownCreateWithNullabilityTypeConsistency(SqlTypeFactoryTest.java:296)

Due to type canonization in RelDataTypeFactory the class of the created type is not the expected one.

Issue Links

• is caused by: CALCITE-4872 UNKNOWN SqlTypeName erroneously treated as NULL
• links to: GitHub Pull Request #2744