[CALCITE-5038] Making AGGREGATE_ANY_PULL_UP_CONSTANTS's test case more rigorous

• Type: Test
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.31.0
• Component/s: tests
• Labels: pull-request-available
• Assignee: Xurenhe
• Reporter: Xurenhe
• Created: 10/Mar/22 12:37
• Updated: 03/Aug/22 16:21
• Resolved: 02/Apr/22 06:19

Description

Some test cases for AGGREGATE_ANY_PULL_UP_CONSTANTS aren't rigorous.

 

//sql in testAggregateDynamicFunction
select hiredate
from sales.emp
where sal is null and hiredate = current_timestamp
group by sal, hiredate
having count(*) > 3
 

But we know that sal in table of sales.emp is not null, so this case should be changed to

 

 

//代码占位符
select hiredate
from sales.emp
where mrg is null and hiredate = current_timestamp
group by mrg, hiredate
having count(*) > 3 

 

Test case of testAggregateConstantKeyRule3 has the same problem.

 

Issue Links

• links to: GitHub Pull Request #2742
• links to: PR-2742