[CALCITE-4921] Nested NATURAL JOINs or JOINs with USING can't find common column

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.38.0
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Aleksey Plekhanov
• Created: 03/Dec/21 08:47
• Updated: 17/Oct/24 22:41
• Resolved: 17/Oct/24 22:41

Description

SqlValidatorUtil#deriveNaturalJoinColumnList can't correctly derive common columns for JOIN if the left hand of it is another NATURAL JOIN or JOIN with USING. For example:

SELECT * FROM (values (1, 1)) as t1(a, b)
NATURAL JOIN (values (1, 1)) as t2(a, c)
NATURAL JOIN (values (1, 1)) as t3(a, d)

Builds incorrect plan:

LogicalProject(A=[$0], B=[$1], C=[$3], A1=[$4], D=[$5])
  LogicalJoin(condition=[true], joinType=[inner])
    LogicalJoin(condition=[=($0, $2)], joinType=[inner])
      LogicalValues(tuples=[[{ 1, 1 }]])
      LogicalValues(tuples=[[{ 1, 1 }]])
    LogicalValues(tuples=[[{ 1, 1 }]])

Queries with USING also have problems:

SELECT * FROM (values (1, 1)) as t1(a, b)
JOIN (values (1, 1)) as t2(a, c) USING (a)
JOIN (values (1, 1)) as t3(a, d) USING (a)

Fails with:

Column name 'A' in USING clause is not unique on one side of join

Issue Links

• links to: GitHub Pull Request #3842