[CALCITE-4884] Provide a new constructor for RelJsonWriter to allow customized JsonBuilder

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.29.0
• Labels: pull-request-available
• Assignee: Chunwei Lei
• Reporter: Chunwei Lei
• Created: 11/Nov/21 02:27
• Updated: 04/Jan/22 08:27
• Resolved: 04/Jan/22 08:27

Description

Currently JsonBuilder in RelJsonWriter cannot be customized due to it being created in the constructor.  We can provide a new constructor for RelJsonWriter to allow customized JsonBuilder.

// code placeholder
public RelJsonWriter() {
  jsonBuilder = new JsonBuilder();
  relList = jsonBuilder.list();
  relJson = new RelJson(jsonBuilder);
}

// the new constrctor suggested.
public RelJsonWriter(JsonBuilder jsonBuilder) {
  this.jsonBuilder = jsonBuilder;
  relList = jsonBuilder.list();
  relJson = new RelJson(jsonBuilder);
}

Issue Links

• relates to: CALCITE-4893 JsonParseException happens when externalizing expressions with escape character from JSON
• links to: GitHub Pull Request #2610