Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-485

Avoid recreate/reparse of CalciteConnectionConfigImpl in CalciteConnectionImpl.config()

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 1.0.0-incubating
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      CalciteConnectionImpl.config is used in lots of places, however the resulting CalciteConnectionConfig is immutable enough, so:
      1) No need to recreate new config object every time
      2) No need to "parse" the values of input map (e.g. like CalciteConnectionProperty.QUOTING.wrap(properties).getEnum(Quoting.class, lex().quoting)).

      I think we can just pre-parse all the values in the CalciteConnectionConfig constructor and store the results to fields.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                vladimirsitnikov Vladimir Sitnikov
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: